Repair Interpolation#1057
Merged
Merged
Conversation
josh-willis-arcadis
approved these changes
May 7, 2026
Contributor
josh-willis-arcadis
left a comment
josh-willis-arcadis
left a comment
There was a problem hiding this comment.
Code looks good. 1 nit is all.
binh-dam-ibigroup
requested changes
May 11, 2026
Contributor
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Wording change for the interpolate checkbox is not needed IMO. Rephrase the "ignore non-blank" text, and move it to i18n.
binh-dam-ibigroup
approved these changes
May 26, 2026
Contributor
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
See comments for further improving the text. Consider updating the corresponding paragraph in the user documentation too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows for use of ibi-group/datatools-server#647